From c0f04081e638e448af18e030ef00c10001908486 Mon Sep 17 00:00:00 2001 From: Thibaut Horel Date: Tue, 6 Jun 2017 19:22:41 -0400 Subject: Cleaner closing of transaction --- data.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data.go b/data.go index 30f8a38..373dddb 100644 --- a/data.go +++ b/data.go @@ -92,6 +92,7 @@ func (store *SqlStore) PutScrobbles(scrobbles []Scrobble) error { if err != nil { return err } + for _, s := range scrobbles { _, err = st.Exec(s.Artist, s.AlbumArtist, s.TrackName, s.Album, s.TrackNumber, s.Duration, s.Time, s.Chosen, s.Mbid, s.MbidComp, @@ -115,6 +116,7 @@ func (store *SqlStore) RecentScrobbles(userId int) []*Scrobble { if err != nil { log.Println(err) } + defer rows.Close() for rows.Next() { scrobble := new(Scrobble) @@ -122,6 +124,5 @@ func (store *SqlStore) RecentScrobbles(userId int) []*Scrobble { &scrobble.TrackName.Name, &scrobble.Time, &scrobble.Image) scrobbles = append(scrobbles, scrobble) } - rows.Close() return scrobbles } -- cgit v1.2.3-70-g09d2