fix up Thibaut's brain damaged code

1 files changed, 8 insertions, 9 deletions

diff --git a/famille.py b/famille.py
index fece79c..0d2c498 100644
--- a/famille.py
+++ b/famille.py
@@ -161,15 +161,14 @@ def edit_user():
                                        error=error)
         except KeyError:
             pass
-        result["notify"] = 1 if "notify" in request.form else 0
-        for key in ['email', 'phone', 'birthday', 'nameday', 'address_line1',
-                    'address_line2', 'address_city_line']:
-            result[key] = request.form[key].encode("utf8")
-        set_string = ",".join("'{0}'='{1}'".format(key, value)
-                              for key,value in result.iteritems())
-        print set_string
-        g.db.execute("UPDATE users SET {} where id=?".format(set_string),
-                     (session['user_id'],))
+        args = tuple(request.form[key].encode("utf8") for key in \
+                     ['email', 'phone', 'birthday', 'nameday', 'address_line1', \
+                     'address_line2', 'address_city_line'])
+        args += ("notify" in request.form, session['user_id'])
+        sqlstr = "UPDATE users SET email= ?, phone=?, birthday=?, nameday=?," \
+        "address_line1=?, address_line2=?, address_city_line=?, notify=? " \
+        "where id=?"
+        g.db.execute(sqlstr, args)
         g.db.commit()
         return redirect(url_for('view_user', user_id=session['user_id']))